Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dateutil as dependency #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove dateutil as dependency #27

wants to merge 1 commit into from

Conversation

fbernhart
Copy link
Contributor

python-dateutil is one of the few dependencies.

It's only used twice in the pypi.py file to create datetime objects from strings. E.g.:

version_date = dateutil.parser.parse(version_date)

But the same can as well easily be achieved with the standard library datetime module:

version_date = datetime.strptime(version_date, "%Y-%m-%dT%H:%M:%S.%fZ")

So this PR aims at removing python-dateutil as dependency and using datetime instead.

miketheman
miketheman approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this out and tested this today - it works as described, and reduces reliance on one external dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketheman miketheman miketheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbernhart @miketheman